Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msom][ci] Build prebootloader, fix macos builds #2683

Merged
merged 2 commits into from
Aug 14, 2023
Merged

[msom][ci] Build prebootloader, fix macos builds #2683

merged 2 commits into from
Aug 14, 2023

Conversation

scott-brust
Copy link
Member

Problem

  1. MSoM platform builds were not building prebootloader-mbr and prebootloader-part1 binaries
  2. Macos builds were failing due to deprecation warnings for intel based macos versions

Solution

  1. Add MSoM platform ID to prebootloader build script
  2. Update macos xcode circle ci config to last supported version

Steps to Test

run pipeline

Example App

build fix only

References

Circle CI deprecation notice

@scott-brust scott-brust added this to the 5.5.0-rc.1 milestone Aug 14, 2023
@scott-brust scott-brust merged commit cd5f84c into develop Aug 14, 2023
@scott-brust scott-brust deleted the fix/test-build-system-xcode-version branch August 14, 2023 23:46
@technobly technobly mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avtolstoy avtolstoy avtolstoy approved these changes

@eberseth eberseth Awaiting requested review from eberseth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.5.0-rc.1
Development

Successfully merging this pull request may close these issues.
2 participants
@scott-brust @avtolstoy